fix: cassie MessageTranslated & replace obsolete "isHeld"#691
Merged
louis1706 merged 3 commits intoExMod-Team:devfrom Dec 19, 2025
Merged
fix: cassie MessageTranslated & replace obsolete "isHeld"#691louis1706 merged 3 commits intoExMod-Team:devfrom
louis1706 merged 3 commits intoExMod-Team:devfrom
Conversation
reversum
changed the title
|
you clearly didn't tested those there obvious issue on these |
I dont see them, can you quote them or something? Cuz this PR looks good to me |
louis1706
reviewed
Dec 18, 2025
louis1706
left a comment
louis1706
left a comment
There was a problem hiding this comment.
also for all of them you modified isHeld by isNoisy but then you keep the isNoisy without replacing it to the isHeld i can get than there was swap but it's should both be used there not only isNoisy
louis1706
approved these changes
Dec 19, 2025
Someone-193
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
MessageTranslated uses the wrong payload and therefore does not send subtitles, only the original message. In addition, MessageTranslated & Message uses “isHeld” where it should be isNoisy.
What is the new behavior? (if this is a feature change)
MessageTranslated now uses the correct CassieTtsPayload and sends the custom subtitles along with it. isNoisy is used in exactly the right places.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other